Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conf-libssl for the mingw-w64 ports #26072

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jun 12, 2024

This commit is extracted from the opam 2.2.0 Windows announcement is intended in part to serve as a demonstration of the changes which need to be made to conf- packages to support the opam 2.2.0 depext scheme for native Windows following the merge of #25861.

The key parts:

  • Constraining old versions of conf- packages
  • Adding conf-mingw-w64-* packages for each architecture with MSYS2 and Cygwin package names
  • Updating the latest version of the main conf- package with a dependency formula and adapting pkg-config to use --personality, etc.

@mseri
Copy link
Member

mseri commented Jun 24, 2024

Wow, that is quite involved, it will make it hard to review and understand them

@dra27
Copy link
Member Author

dra27 commented Jun 25, 2024

Indeed, although it should be largely one-time pain (it's not like the conf- packages get materially updated that frequently) and, as in #26102, I'm very happy to be pinged to review them (even if that's slightly weird for the ones I've actually opened!)

@mseri mseri merged commit f5f3839 into ocaml:master Jun 27, 2024
1 of 2 checks passed
@dra27 dra27 deleted the windows-conf-libssl branch June 27, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants