Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] mimic (2 packages) (0.0.9) #26100

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dinosaure
Copy link
Contributor

@hannesm
Copy link
Member

hannesm commented Jun 17, 2024

it looks like the release is not published on github... :/

@dinosaure
Copy link
Contributor Author

I just fixed the release. Let's see the CI.

@hannesm
Copy link
Member

hannesm commented Jun 17, 2024

while this is nice, unfortunately we'll need another patch for mimic -- dinosaure/mimic#28 -- otherwise it won't work.. so please do not merge this, but instead wait for @dinosaure re-cutting the release. sorry for all the trouble.

CHANGES:

* Re-introduce the DNS stack into mimic to be able to resolve domain-names
  (@dinosaure, @hannesm, dinosaure/mimic#24, dinosaure/mimic#26, dinosaure/mimic#28)
@dinosaure
Copy link
Contributor Author

The package is re-released, good to review 👍.

@hannesm
Copy link
Member

hannesm commented Jun 17, 2024

This looks fine. There are CI failures I haven't seen earlier (unrelated to this PR, maybe to dune 3.16?):

#=== ERROR while compiling alcotest.1.7.0 =====================================#
# context              2.0.10 | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/alcotest.1.7.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p alcotest -j 39 @install
# exit-code            1
# env-file             ~/.opam/log/alcotest-44-548b09.env
# output-file          ~/.opam/log/alcotest-44-548b09.out
### output ###
# File "src/alcotest-engine/dune", line 26, characters 2-9:
# 26 |   fmt.cli
#        ^^^^^^^
# Error: Library "fmt.cli" in /home/opam/.opam/4.14/lib/fmt is hidden
# (unsatisfied 'exists_if').
# -> required by library "alcotest.engine" in
#    _build/default/src/alcotest-engine
# -> required by _build/default/META.alcotest
# -> required by _build/install/default/lib/alcotest/META
# -> required by _build/default/alcotest.install
# -> required by alias install

This is with opam 2.0 (and OCaml 4.14/5.2). Not sure in which lifecycle opam 2.0 is?

To me, this looks unrelated to this PR, and this is good to merge (and would unlock some other releases).

@hannesm
Copy link
Member

hannesm commented Jun 24, 2024

@samoht this is needed for the next mirage release (to unblock example unikernels like git, http)

@avsm
Copy link
Member

avsm commented Jun 24, 2024

An odd opam 2.0 failure, but it works on newer opams so I think we can fix this async.

#=== ERROR while compiling conf-pkg-config.3 ==================================#
# context              2.0.10 | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/conf-pkg-config.3
# command              ~/.opam/opam-init/hooks/sandbox.sh build pkg-config --help
# exit-code            1
# env-file             ~/.opam/log/conf-pkg-config-44-8b8a2d.env
# output-file          ~/.opam/log/conf-pkg-config-44-8b8a2d.out
### output ###
# bwrap: execvp pkg-config: No such file or directory


#=== ERROR while compiling alcotest.1.7.0 =====================================#
# context              2.0.10 | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/alcotest.1.7.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p alcotest -j 39 @install
# exit-code            1
# env-file             ~/.opam/log/alcotest-44-548b09.env
# output-file          ~/.opam/log/alcotest-44-548b09.out
### output ###
# File "src/alcotest-engine/dune", line 26, characters 2-9:
# 26 |   fmt.cli
#        ^^^^^^^
# Error: Library "fmt.cli" in /home/opam/.opam/4.14/lib/fmt is hidden
# (unsatisfied 'exists_if').
# -> required by library "alcotest.engine" in
#    _build/default/src/alcotest-engine
# -> required by _build/default/META.alcotest
# -> required by _build/install/default/lib/alcotest/META
# -> required by _build/default/alcotest.install
# -> required by alias install

@avsm avsm merged commit fe0cf6f into ocaml:master Jun 24, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants