-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] mimic (2 packages) (0.0.9) #26100
Conversation
it looks like the release is not published on github... :/ |
a19eeb5
to
fdf9a54
Compare
I just fixed the release. Let's see the CI. |
while this is nice, unfortunately we'll need another patch for mimic -- dinosaure/mimic#28 -- otherwise it won't work.. so please do not merge this, but instead wait for @dinosaure re-cutting the release. sorry for all the trouble. |
CHANGES: * Re-introduce the DNS stack into mimic to be able to resolve domain-names (@dinosaure, @hannesm, dinosaure/mimic#24, dinosaure/mimic#26, dinosaure/mimic#28)
fdf9a54
to
c53bba9
Compare
The package is re-released, good to review 👍. |
This looks fine. There are CI failures I haven't seen earlier (unrelated to this PR, maybe to dune 3.16?):
This is with opam 2.0 (and OCaml 4.14/5.2). Not sure in which lifecycle opam 2.0 is? To me, this looks unrelated to this PR, and this is good to merge (and would unlock some other releases). |
@samoht this is needed for the next mirage release (to unblock example unikernels like git, http) |
An odd opam 2.0 failure, but it works on newer opams so I think we can fix this async.
|
A simple protocol dispatcher
CHANGES:
(@dinosaure, @hannesm, Re-introduce dns for mimic to be sure that the injected happy-eyeballs is able to resolve domain-names dinosaure/mimic#24, mimic-happy-eyeballs: other adjustments dinosaure/mimic#26)