merge cmd_trans to main #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite generic commands with one request
… query on command view
Replace Hard-Coded Table with System Table Mapping for cmdName
Matches the latest table structure of obkv redis
Modis performance optimizing
fix get server where tenant is not existed
WeiXinChan
reviewed
Sep 19, 2024
cmd/modis/main.go
Outdated
| @@ -43,15 +44,18 @@ func main() { | |||
| // go func() { | |||
There was a problem hiding this comment.
maybe we should remove unused code
| res, err := ctx.CodecCtx.DB.Storage.Expire(ctx.CodecCtx.DB.Ctx, ctx.CodecCtx.DB.ID, key, at) | ||
| func ExpireCommon(ctx *CmdContext) error { | ||
| var err error | ||
| ctx.OutContent, err = GenericCmdWithKey(ctx, "get") |
There was a problem hiding this comment.
type, It should be cmdName, which has been modified.
updata obkv_table_client, remove redis pcode and use table pcode
fix review
reset redis use table pcode
fix set err msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
merge cmd_trans to main, to fit oceanbase 4.2.5
Solution Description