-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix netcdf issue for Hamtide tests #189
Conversation
838bbe9
to
31a9c28
Compare
@WPringle I tried to address a couple of issues for tests to run successfully in this PR locally everything works, but now I see errors in macos version! When I look at the diff (I outputted the diff in the test for debugging) I see some section of tides that are different from the reference (on linux on my machine it's fine). If you're working on a mac can you please run tests and see what you get? |
@SorooshMani-NOAA On Argonne linux machine using python 3.10 I'm getting a failed test for |
I had to update the station references. For some reason the order of stations changed (maybe due to a change in searvey or even server side). Make sure you have the latest reference files for local testing. What about macos? Were you able to test on a mac? |
Thanks to @AtiehAlipour-NOAA we ran the tests on a mac machine and we get a crash from The run env was created by conda with
If we don't install On the CI for mac brew install hdf5
brew install netcdf |
After more testing via updating tests and ref files it seems the reason behind the difference is how grid-data |
3eb7816
to
6a2e07c
Compare
32a5b99
to
976c57d
Compare
Tests that required Hamtide failed due to an issue with the latest version of netcdf library installed using pip. Fixes #188