Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for #12293 - split CTD and DO cabled streams. #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes for #12293 - split CTD and DO cabled streams. #34

wants to merge 1 commit into from

Conversation

danmergens
Copy link
Contributor

  • updated and sorted stream_metadata
  • added time range utility, extract_time
  • added tests to verify computation of dissolved oxygen products
  • corrected metbk hourly test

Change-Id: I954a5d2ed5c11244a7f765694d54f09264eb42ec

@danmergens
Changes for #12293 - split CTD and DO cabled streams.
c2876ed 
- updated and sorted stream_metadata
- added time range utility, extract_time
- added tests to verify computation of dissolved oxygen products
- corrected metbk hourly test

Change-Id: I954a5d2ed5c11244a7f765694d54f09264eb42ec
renegelinas
renegelinas approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@renegelinas renegelinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the alphabetizing of stream_metadata.csv!

tlfish3638
tlfish3638 reviewed Nov 21, 2017
View reviewed changes
Copy link
Contributor

@tlfish3638 tlfish3638 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this code well enough to offer truly useful feedback but I didn't see anything that concerns me.

@danmergens
Copy link
Contributor Author

Thanks for the reviews. It's not critical that this get updated. There are some nice test case additions that just show that the updates are working properly.

@rjelkins
Copy link
Contributor

what's the unit test failure about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfish3638 tlfish3638 tlfish3638 left review comments

@renegelinas renegelinas renegelinas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmergens @rjelkins @renegelinas @tlfish3638