-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use timestamp instead of block number in predictoor #780
Use timestamp instead of block number in predictoor #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
} | ||
|
||
function soonestBlockToPredict(uint256 prediction_block) public view returns (uint256) { | ||
function soonestEpochToPredict(uint256 prediction_ts) public view returns (uint256) { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
…s-for-prediction Hide stake amounts for prediction epoch & Allow predictoors modify their stake amount
} | ||
|
||
function getTotalStake( | ||
uint256 epoch_start |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
…fter_trueval expose agg predval after trueval
I just noticed this PR. Why isn't it merged? (And it's an important thing to do) cc @trizin |
Fixes #779
Changes proposed in this PR: