Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #471: Update ohlcv-data-factory when predictoor agent initializes #551

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

idiom-bytes
Copy link
Member

Fixes #471

This PR is a result of closing PR #513, branching from latest main, and cherry-picking from 513.

Changes proposed in this PR:

  • When predictoor_agent initializes, have ohlcv_datafactory and any other data components update right away
  • By the time the agents try to take action, their data should now be up-to-date
  • Create tests showing that agent is behaving as expected

@idiom-bytes idiom-bytes requested review from trizin and trentmc and removed request for calina-c, kdetry and trizin January 19, 2024 21:18
@idiom-bytes
Copy link
Member Author

Hi @trentmc , this is a small update to change the main-loop of predictoor agents, so that they initialize all data required ahead of time of needing to make a prediction.

I have asked others to review, but I believe you'll be the most efficient/aligned with this.

Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

Note: there's a follow-on solution for separate lake-filling processes. See #564 "Lake supports >1 writers, incl predictoor bots and >1 pdr lakes".

@idiom-bytes idiom-bytes merged commit 1257603 into main Jan 23, 2024
5 checks passed
@idiom-bytes idiom-bytes deleted the issue471b-initialize-ohlcv-predictoor-agent branch January 23, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Predictoor] Update ohlcv_factory when predictor_agent inits
2 participants