Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created download functionality. #4

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Created download functionality. #4

wants to merge 17 commits into from
+386 −31

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Oct 3, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • create download feature on the vs code extension
Screenshot 2024-10-14 at 22 02 19 Screenshot 2024-10-14 at 22 02 10

@mariacarmina mariacarmina marked this pull request as ready for review October 14, 2024 12:02
@mariacarmina mariacarmina self-assigned this Oct 14, 2024
jamiehewitt15
jamiehewitt15 reviewed Oct 14, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
jamiehewitt15
jamiehewitt15 reviewed Oct 14, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
jamiehewitt15
jamiehewitt15 reviewed Oct 14, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
jamiehewitt15
jamiehewitt15 reviewed Oct 14, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
jamiehewitt15
jamiehewitt15 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should only ask for the private key once, we can move it to the top section and then we use the same private key for publishing & downloading. We can do that on a separate branch

@mariacarmina
Copy link
Member Author

Looks good. I think we should only ask for the private key once, we can move it to the top section and then we use the same private key for publishing & downloading. We can do that on a separate branch

Thank you @jamiehewitt15 ! I think it's better to include here too, it's not a big modification.

@jamiehewitt15
Copy link
Member

I think it's better to include here too, it's not a big modification.

Ok yeah, makes sense

@mariacarmina
Copy link
Member Author

I think it's better to include here too, it's not a big modification.

Ok yeah, makes sense

Done.

jamiehewitt15
jamiehewitt15 reviewed Oct 15, 2024
View reviewed changes
src/viewProvider.ts Outdated
<label for="assetDidInput">Asset DID</label>
<input id="assetDidInput" placeholder="Enter your asset DID" />

<label for="filePathInput">File Path</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, file path is a bit of a confusing name as they don't have the file yet. It might be better to say download path to indicate this is where the file is going to be saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariacarmina @jamiehewitt15