Upgraded package versions of most packages to latest TS 3 support #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes for @demurgos new kryo library (other was not ts 3.0 compat). One nullable function might be wrong. TSLint fixes as well. A few TSLint items do not pass (were there before).
|
errors are the whitespace errors I mentioned not sure what is complaining about but @demurgos can fix before merging. Several files I had not touched so not sure if its the lint version the lint rules etc but fix did not seem to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108, closes #103, closes #92, closes #94, closes #91, closes #95, closes #98, closes #99.
Major changes for @demurgos new kryo library (other was not ts 3.0 compat). One nullable function might be wrong. TSLint fixes as well. A few TSLint items do not pass (were there before).
There is excess json decoding for the new reader support (as it decodes on its own). Could switch to either pass an object or not do the eval decode first.
The nullable in api-profile.ts I couldn't figure out how to update for the new kyro. As I couldn't get that working avatarUrl changed to a Any. I tried it as a Url | null but I am guessing without that nullable function it just wasn't working.