-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocompletion for fish shell #38
Conversation
Auto-detect the correct location using pkg-config to determine the vendor completion directory for fish. Create the script file in that location.
Also add debug logging about the path that we're writing to
- single quote - unnecessary semi-colon - `completions` variable any type
Thanks for the contribution! Before we can merge this, we need @functionalStoic to sign the Salesforce.com Contributor License Agreement. |
Taking a look! Can you merge in master so it'll run the latest suite? Thanks! |
@functionalStoic You need any help? |
@pksunkara Sure, I haven't been able to get back to it because of current obligations. Thanks! |
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jason Sooter <j***@t***.edu>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
Cleaning up - if you think this PR is still valid, reopen it. Thanks! |
@RasPhilCo I would like to help out with this. Can you please reopen it? |
Adds an `autocomplete` command to flub which can be used to generate autocomplete config for bash and zsh. This is provided "for free" by using [@oclif/plugin-autocomplete](https://github.com/oclif/plugin-autocomplete). fish is not supported, but possibly could be with this PR: oclif/plugin-autocomplete#38 We could either wait for the feature to come, release a custom plugin with that PR in the meantime, or open our own PR to add it.
Fixes #5
@waveaccounting should definitely get the credit
Add autocompletion for fish shell #5 (comment)
Hope it helps move it along as I'm excited about Fish shell autocompletion for the Twilio CLI