Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle spaces in node/npm path #718

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: handle spaces in node/npm path #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c9f799
fix: handle spaces in node/npm path
cristiand391 Nov 13, 2023
dc733ed
chore: add comment
cristiand391 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ export default class Plugins {
this.debug(`Using node executable located at: ${nodeExecutable}`)
this.debug(`Using npm executable located at: ${npmCli}`)

const command = `${nodeExecutable} ${npmCli} show ${name} dist-tags`
// wrap node and path in double quotes to deal with spaces
const command = `"${nodeExecutable}" "${npmCli}" show ${name} dist-tags`

let npmShowResult
try {
Expand Down
3 changes: 1 addition & 2 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ export async function findNode(root: string): Promise<string> {
// Check to see if node is installed
const nodeShellString = shelljs.which('node')
if (nodeShellString?.code === 0 && nodeShellString?.stdout) {
// wrap node path in double quotes to deal with spaces
return `"${nodeShellString.stdout}"`
return `${nodeShellString.stdout}`
}

const err = new Error('Cannot locate node executable.')
Expand Down
Loading