Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there — I noticed that using spread syntax on the error object strips away a lot of helpful data that we use for our assertions so this PR helps preserve that information.
You can reproduce this by opening up a Node REPL and typing in the following:
Note how the
name
property on the error object is lost entirely.This PR updates this logic to use
Object.assign()
instead — try the following in your Node REPL and observe that the error'sname
information is preserved:Thanks again for all your work on this library!