Update maturin version to ~=1.0 #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that Maturin is post-1.0, maybe we should use a compatible version specifier like |
This allows building blake3 with maturin 1.0, 1.1, 1.2 and future compatible versions. The package was built and tested with each latest minor version of maturin since 0.14 (0.15.3, 1.0.1, 1.1.0 and 1.2.3) by incrementally increasing the upper bound and running : ``` # edit version then : pip install --verbose --no-binary :all: . && pytest ``` https://www.maturin.rs/changelog
kmichel-aiven
force-pushed
the
kmichel-maturin-update
branch
from
0576f87
to
7837565
Compare
kmichel-aiven
changed the title
Good point. I've set it to ~=1.0 instead of ~=1.2 if that's ok. That still allows compatibility with the latest but reduces the pain on Linux distribution that still package maturin 1.0 or 1.1 (Fedora 37 to 39, Debian sid). Since the build also works with these versions, no need to block them ? |
|
Hi, did you have time to look at this ? |
oconnor663
force-pushed
the
master
branch
2 times, most recently
from
84999bb
to
3ffe734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building blake3 with maturin 1.0, 1.1, 1.2 and future compatible versions.
The package was built and tested with each latest minor version of maturin since 0.14 (0.15.3, 1.0.1, 1.1.0 and 1.2.3) by incrementally increasing the upper bound and running :
https://www.maturin.rs/changelog