Skip to content

Commit

Permalink
add a TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
oconnor663 committed Feb 23, 2022
1 parent 501c4aa commit df53648
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/windows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ pub(crate) fn dup<F: AsRawHandle>(wrapper: &F) -> io::Result<File> {
// deadlocks when the handle in question is a stdout pipe. To get that
// right, we explicitly make the necessary system calls here, just like
// libstd apart from that one flag.
// TODO: The fix for this issue shipped in Rust 1.40 (December 2019). When
// we bump the MSRV past that point, we can go ahead and delete this
// workaround. Until then, no rush.
let source_handle = wrapper.as_raw_handle() as HANDLE;
let desired_access = 0; // Ignored because of DUPLICATE_SAME_ACCESS.
let inherit_handle = false as BOOL; // <-- Libstd sets this to true!
Expand Down

0 comments on commit df53648

Please sign in to comment.