Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column sizing becomes corrupted when window/region size becomes too small #1656

Closed
JSandusky opened this issue Mar 3, 2018 · 4 comments
Closed

Comments

@JSandusky
Copy link

JSandusky commented Mar 3, 2018

When visible columns are resized to small extremes the scaling becomes brittle. In the demo it appears to always go to the extremes while in some live-code it looks like signs are wrapping around (columns start to size off into the wrong direction).

Reproducing:

  • Make the columns examples in the Demo visible
  • Resize the window to an extremely small size (ie. as small as it will go)
  • Expand window back to a reasonable size

Image of results (from demo):

imguirepro

@ocornut
Copy link
Owner

ocornut commented Mar 3, 2018

Oh wow, I think I broke something serious in my pass on columns (a few months ago). Will look at this at this is pretty bad.

EDIT Broken by b016215 for #1499

ocornut added a commit that referenced this issue Mar 4, 2018
ocornut added a commit that referenced this issue Mar 4, 2018
…p introduced by #913 was ok as it didn't write back into the storage, which #1499 started doing making it destructive. Right now I don't think the clamp is needed at all. It had uses (eg: hide the issue fixed by bf7481e).
@ocornut
Copy link
Owner

ocornut commented Mar 4, 2018

@JSandusky this should be fixed now.

fyi @ggtucker:
The OffsetNorm clamp introduced by #913 was ok as it didn't write back into the storage, which the refactor commit b016215 (for #1499) started doing, making it a destructive operation. Right now I don't think the clamp is needed at all. It nicely hid the padding issue fixed by bf7481e, what else? You probably won't have an exact answer at the moment, but if you have a chance to update let me know if you find any regression in there.

@JSandusky
Copy link
Author

Confirmed as fixed in my live-case and the imgui demo. Since you've referenced this from other issues I'll leave it to you decide when to close the issue.

@ocornut
Copy link
Owner

ocornut commented May 15, 2018

Closing this as solved.
(Been looking at columns a little to try to spec full-featured columns/table..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants