Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle situation when WM_*BUTTONDOWN and WM_*BUTTONUP received at the… #1320

Closed
wants to merge 1 commit into from
Closed

Handle situation when WM_*BUTTONDOWN and WM_*BUTTONUP received at the… #1320

wants to merge 1 commit into from

Conversation

plzombie
Copy link

… same time, within one frame

Usually happens with touch screens, when user taps on a window

Handle situation when WM_*BUTTONDOWN and WM_*BUTTONUP received at the…
4c0e1b4 
… same time, within one frame

Usually happens with touch screens, when user taps on a window
@ocornut ocornut added the inputs label Sep 23, 2019
@ocornut ocornut force-pushed the master branch 2 times, most recently from 0c1e5bd to bb6a60b Compare August 27, 2021 19:10
@ocornut ocornut force-pushed the master branch 2 times, most recently from 8b83e0a to d735066 Compare December 13, 2021 11:31
@ocornut ocornut force-pushed the master branch 2 times, most recently from b3b85d8 to 0755767 Compare January 17, 2022 14:21
ocornut pushed a commit that referenced this pull request Jan 17, 2022
@thedmd @ocornut
IO: Added AddMousePosEvent(), AddMouseButtonEvent(), AddMouseWheelEve…
b8e56dc 
…nt() api + updated all Backends. (#4858) (input queue code will be next commit)

Details: note that SDL, OSX and GLFW backends removed recording of MouseJustPressed[] which will be unnecessary with input queue (which is the NEXT commit). (#2787, #1992, #3383, #2525, #1320)
ocornut added a commit that referenced this pull request Jan 17, 2022
@ocornut
IO: Added input queue. (#4858, #2787, #1992, #3383, #2525, #1320)
7374b96
@ocornut
Copy link
Owner

ocornut commented Jan 17, 2022

Better late than never, apologies for not reacting sooner.

Dear imgui 1.87 WIP now uses a new IO api (e.g. io.AddKeyEvent() io.AddMouseButtonEvent() etc.) which implement an input trickling queue, normally solving this problem correctly and everywhere for all types of inputs. We'll monitor feedback and expect bugs to have creeped as we reoverhauled that system.

See e.g.

  • new IO api b8e56dc
  • input queue 7374b96
    There are many other commits but those should provide a good general sense of what changed.

Also see #4858 for a general overview (we'll improve this topic soon).

@ocornut ocornut closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backends inputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plzombie @ocornut