Numeric keypad enter is enabled on glfw #2005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocornut Are you going to merge this? |
|
Thanks @durswd for your PR. Also linking to #1924. I don't know yet if this can be merged as-is. I think this need to be tackled more widely and seriously, if we decide to actually add all standard keys to the enum. May want to revisit the input mapping model completely. You may just do something along the line of ~ |
|
AFAIK it's Ok to leave some keys not added since there're always differences among the support of keys of those GLs. |
|
Fixed by #2625, closing this. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric keypad enter was disabled on glfw
It is enabled on Win32 + DirectX
It is disabled on glfw + OpenGL
Numeric keypad numbers are enabled on both platforms.
So I make numeric keypad enter enabled.