Fix for not being able to enter certain characters in InputText on german keyboard #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me characters if CTRL key press is detected AND ALT key press is detected in Imgui::InputTextEx
ocornut
added a commit
that referenced
this pull request
Oct 11, 2015
InputText: Fix for not being able to enter certain characters in InputText on german keyboard
ocornut
added a commit
that referenced
this pull request
Oct 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On german keyboards the user can't enter lots of chars which use AltGr as a modifier (e.g '{' '[' ']' '}' '' ) because of:
“Alt Gr” on german (and other) keyboards – “Alt Gr” is not the same as right-hand “Alt” on US keyboards, it essentially is a short-cut for “Control” and right-hand “Alt”. (from http://blog.molecular-matters.com/2011/09/05/properly-handling-keyboard-input/)
With the existing code all chars are suppressed when CTRL-press is detected.
Solution:
Don't suppress characters if CTRL AND ALT key press is detected in Imgui::InputTextEx.
Ctrl+C, Ctrl+V etc still work as expected.