Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an integer overflow and div-by-zero in sliders #6679

Closed
wants to merge 1 commit into from

Conversation

jbarthelmes
Copy link
Contributor

Fixes #6675

@jbarthelmes
Copy link
Contributor Author

jbarthelmes commented Aug 2, 2023

(min != max) => (v_range != 0) may already be checked elsewhere, I just noticed the possible div by zero while editing

@ocornut
Copy link
Owner

ocornut commented Aug 3, 2023

Merged with tweaks as b7a7d67 as your version caused a warning on implicit casting to float + added comment. Thanks!

@ocornut ocornut closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signed overflow in "slider s32 full" demo widget
2 participants