fixing: Use Unicode version of WndProc to get correct input under Windows UTF-8 code page.

[kimidaisuki22]

default code page.

UTF-8 code page

UTF-8 manifest file: (need Windows 10 1903 or newer)

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
  <assemblyIdentity type="win32" name="..." version="6.0.0.0"/>
  <application>
    <windowsSettings>
      <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
    </windowsSettings>
  </application>
</assembly>

[PathogenDavid]

These two should be changed to explicit W as well:

imgui/backends/imgui_impl_glfw.cpp

Line 662 in 4a24264

::SetWindowLongPtr((HWND)main_viewport->PlatformHandleRaw, GWLP_WNDPROC, (LONG_PTR)bd->GlfwWndProc);

imgui/backends/imgui_impl_glfw.cpp

Line 496 in 4a24264

return ::CallWindowProc(bd->GlfwWndProc, hWnd, msg, wParam, lParam);

(I'm actually surprised your fix works without the last one.)

Since GLFW explicitly uses W functions, we should do so as well since using A functions with resources associated with a W window class can be problematic. (Ideally we'd just #define UNICODE in this file, but that'd cause issues for unity builds.)

[kimidaisuki22]

These two should be changed to explicit W as well:

imgui/backends/imgui_impl_glfw.cpp

Line 662 in 4a24264

::SetWindowLongPtr((HWND)main_viewport->PlatformHandleRaw, GWLP_WNDPROC, (LONG_PTR)bd->GlfwWndProc);

imgui/backends/imgui_impl_glfw.cpp

Line 496 in 4a24264

return ::CallWindowProc(bd->GlfwWndProc, hWnd, msg, wParam, lParam);

(I'm actually surprised your fix works without the last one.)

Since GLFW explicitly uses W functions, we should do so as well since using A functions with resources associated with a W window class can be problematic. (Ideally we'd just #define UNICODE in this file, but that'd cause issues for unity builds.)

msg, wParam and lParam are from the Unicode version, so the problem is solved even CallWindowProcA is called here.

Thank you, I changed them to the 'W' version.

[ocornut]

Merged as 240ab58, thank you very much !