Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary attributes should be at least Recommended #664

Closed
pagbabian-splunk opened this issue Jun 1, 2023 · 1 comment · Fixed by #974
Closed

Primary attributes should be at least Recommended #664

pagbabian-splunk opened this issue Jun 1, 2023 · 1 comment · Fixed by #974
Assignees
@pagbabian-splunk
Labels
framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes v1.2.0 Changes marked for version v1.2.0 of OCSF

Comments

@pagbabian-splunk
Copy link
Contributor

There are a number of attributes that are marked as Optional and Primary. A primary attribute for a class should be Recommended or Required. Typically context attributes will be Optional, although there is no firm 1 to 1 for that.
@pagbabian-splunk pagbabian-splunk self-assigned this Jun 1, 2023
@pagbabian-splunk pagbabian-splunk added framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes labels Jun 1, 2023
@floydtree
Copy link
Contributor

Everyone is in agreement, good to implement.

@floydtree floydtree added the v1.2.0 Changes marked for version v1.2.0 of OCSF label Jan 9, 2024
@alanisaac alanisaac mentioned this issue Feb 22, 2024
Merged
@alanisaac alanisaac mentioned this issue Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pagbabian-splunk pagbabian-splunk

Labels
framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make primary attributes at least recommended alanisaac/ocsf-schema
2 participants
@pagbabian-splunk @floydtree