Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make primary attributes at least recommended #974

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Make primary attributes at least recommended #974

merged 3 commits into from
Feb 27, 2024

Conversation

alanisaac
Copy link
Contributor

@alanisaac alanisaac commented Feb 22, 2024 •
edited
Loading

Related Issue:

Fixes #664

Description of changes:

This PR makes two changes:

  • Updates the metaschema to enforce that attributes labeled with group: primary may not be labeled with requirement: optional
  • Updates existing violations of that new rule so that all existing primary / optional attributes are made primary / recommended

@alanisaac alanisaac marked this pull request as ready for review February 22, 2024 17:58
floydtree
floydtree approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will help add consistency in the framework.

@pagbabian-splunk
Copy link
Contributor

pagbabian-splunk commented Feb 24, 2024 •
edited
Loading

I agree with this one too - I think there was an issue to this effect some time ago.

@dkolbly dkolbly self-requested a review February 27, 2024 17:03
@floydtree floydtree merged commit 90b6ee3 into ocsf:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmouritzen-splunk rmouritzen-splunk rmouritzen-splunk approved these changes

@query-jeremy query-jeremy query-jeremy approved these changes

@floydtree floydtree floydtree approved these changes

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@dkolbly dkolbly dkolbly approved these changes

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

@mikeradka mikeradka Awaiting requested review from mikeradka mikeradka is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary attributes should be at least Recommended
6 participants
@alanisaac @pagbabian-splunk @dkolbly @floydtree @query-jeremy @rmouritzen-splunk