Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying coordinates attribute in the Geo Location object #963

Closed
floydtree opened this issue Feb 13, 2024 · 1 comment
Closed

Simplifying coordinates attribute in the Geo Location object #963

floydtree opened this issue Feb 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request v1.2.0 Changes marked for version v1.2.0 of OCSF

Comments

@floydtree
Copy link
Contributor

floydtree commented Feb 13, 2024

Today, our geolocation object contains a coordinates array which is intended to house lon, lat in decimal degrees. As one can imagine, order of the elements in this array would be very important to convey the geo coordinates accurately. There in lies the issue, since it is an array we cannot really prescribe what the order should be. Additionally, there is no single, universally followed convention, MaxMind, Google Maps both follow lat, lon however, GeoJson standard, that OCSF's description refers to, follows lon, lat standard. I think we are adding unnecessary ambiguity for producers, mappers and consumers of OCSF data.

The simple solution to alleviate this ambiguity is to introduce explicit attributes in the object. Two new attributes should be added to the geolocation object - lat, long and the existing coordinates array attribute should be deprecated. Happy to discuss further.

This was discussed amongst a few community members in Feb 8th, 2024 Mapping work-stream call.

@floydtree floydtree added enhancement New feature or request v1.2.0 Changes marked for version v1.2.0 of OCSF labels Feb 13, 2024
@floydtree floydtree self-assigned this Feb 14, 2024
@query-jeremy
Copy link
Contributor

If we're adding to the geolocation object, we should consider an optional geohash property. Geohashes are information dense, searchable, and flexible in precision.

I can't represent a current need for them but they can be very useful for certain location informed analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Development

No branches or pull requests

2 participants