Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of geo location object #971

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

floydtree
Copy link
Contributor

Related Issue: #963

Description of changes:

  1. Deprecating coordinates in favor of new lat, long attributes in the location object
  2. Adding geohash attribute to location object.
  3. Unrelated - cleaning up changelog items, correcting a few errors.

@floydtree floydtree added enhancement New feature or request v1.2.0 Changes marked for version v1.2.0 of OCSF labels Feb 20, 2024
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
objects/location.json Show resolved Hide resolved
Copy link
Contributor

@query-jeremy query-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for being responsive to the feedback!

Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad you fixed this

@Aniak5 Aniak5 merged commit c0f9c49 into ocsf:main Feb 22, 2024
2 checks passed
@floydtree floydtree deleted the geo-coordinates branch February 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants