-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a number of new observables, both dictionary types, and dictionary attributes #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary attributes. Moved the security_level_id and related attributes to be better sorted in alphabetic order. Signed-off-by: Paul Agbabian <[email protected]>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
April 11, 2024 23:47
Aniak5
reviewed
Apr 12, 2024
…bject and adjusted the user_agent number to fill the gap. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
…c attribute. Signed-off-by: Paul Agbabian <[email protected]>
query-jeremy
previously approved these changes
Apr 12, 2024
floydtree
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weren't we also adding cve.uid
to the observable list?
(The PR description needs to be updated)
Signed-off-by: Paul Agbabian <[email protected]>
Aniak5
reviewed
Apr 12, 2024
Aniak5
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Paul Agbabian <[email protected]>
Aniak5
approved these changes
Apr 12, 2024
zschmerber
approved these changes
Apr 12, 2024
floydtree
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: (PR #961)
Description of changes:
Added two new dictionary type observables:
port_t
andsubnet_t
from PR #961Added
cwe.uid
andcve.uid
object-specific type observables: modified version ofcwe_uid
from PR #961Added three new dictionary attribute observables (new feature in server):
Process ID
HTTP User-Agent
from PR #961Added two new dictionary attribute observables (new feature in server):
Command Line
Country
Moved the security_level_id and related attributes to be better sorted in alphabetic order.