feat: add file_result to File Hosting Activity

[shellcromancer]

Related Issue:

Discussion in Slack here and discussed during the Network meeting on 2024-04-17.

The file hosting activity class has the File object, which has an owner attribute, but this doesn't make it easy to model the change. Should this class get a file_result attribute so that both the old and new owner can be represented? That way it'd be file.owner for the old owner, and file_result.owner for the new/updated owner of a document

Really good use case observation. If there are more transfers besides owner, then a file_result of type File would make sense, but if it is only a change of owner it could be handled in a lighter way, given how rich of an object File is (e.g. new_owner - I don't really like that though, it's a bit too kludgy for one use case). If the name could change, the size could change, its path changes, any of its extended attributes, its classification: having a file_result makes sense. There is a Rename activity already, and so I think your suggestion is the right one. I can imagine other activities in the future too.

Description of changes:

This addresses use-cases where the the activity was an Update but the changes were unable to be captured such as a new file.owner, file.size, file.name, etc.

[mikeradka]

Another question here for clarification - is the intent for file_result to represent a new file object? If so, this object may have to be set as type: "file" in the dictionary.

[mikeradka]

Another question here for clarification - is the intent for file_result to represent a new file object? If so, this object may have to be set as type: "file" in the dictionary.

Disregard. I see it already belongs to the dictionary.

[mikeradka]

This looks great now.

[Aniak5]

LGTM!