Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds ext attribute to File object #1046

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

shellcromancer
Copy link
Contributor

@shellcromancer shellcromancer commented Apr 17, 2024

Related Issue:

Closes #1043

Description of changes:

This adds a new ext attribute to the File object

@mikeradka mikeradka added v1.3.0 Changes marked for v1.3.0 of OCSF enhancement New feature or request non_breaking Non Breaking, backwards compatible changes labels Apr 17, 2024
@shellcromancer shellcromancer force-pushed the file_extension branch 2 times, most recently from bb92c3c to e4c6ed6 Compare April 17, 2024 19:20
@shellcromancer shellcromancer changed the title feat: adds file_extension attribute to File object feat: adds ext attribute to File object Apr 17, 2024
Aniak5
Aniak5 previously approved these changes Apr 18, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

floydtree
floydtree previously approved these changes Apr 18, 2024
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a consideration about the dictionary's caption/description.

dictionary.json Outdated Show resolved Hide resolved
objects/file.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now.

@mikeradka mikeradka merged commit c4c772e into ocsf:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ext attribute to File object
6 participants