Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Lifecycle: Add Update, Restart, Enable, Disable activities #1064

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Application Lifecycle: Add Update, Restart, Enable, Disable activities #1064

merged 2 commits into from
Apr 25, 2024

Conversation

mikeradka
Copy link
Contributor

Related Issue:

#1054

Description of changes:

This PR adds these activities to the Application Lifecycle class:

  • Restart
  • Enable
  • Disable
  • Update

For grammar consistency, it also adds a description to each caption.

image

@mikeradka mikeradka added enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream non_breaking Non Breaking, backwards compatible changes application_activity Issues related to Application Activity Category v1.3.0 Changes marked for v1.3.0 of OCSF labels Apr 24, 2024
@mikeradka mikeradka self-assigned this Apr 24, 2024
@mikeradka mikeradka mentioned this pull request Apr 24, 2024
Closed
@mikeradka
Update CHANGELOG
da6346c 
Signed-off-by: Michael Radka <[email protected]>
floydtree
floydtree approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

Aniak5
Aniak5 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zschmerber zschmerber merged commit 86b5feb into ocsf:main Apr 25, 2024
2 checks passed
@mikeradka mikeradka deleted the update_application_activities branch April 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniak5 Aniak5 Aniak5 approved these changes

@zschmerber zschmerber zschmerber approved these changes

@floydtree floydtree floydtree approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

Assignees

@mikeradka mikeradka

Labels
application_activity Issues related to Application Activity Category enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeradka @Aniak5 @zschmerber @floydtree