Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup of schema definition files #1071

Merged
merged 8 commits into from
May 3, 2024

Conversation

floydtree
Copy link
Contributor

@floydtree floydtree commented May 2, 2024

Related Issue:

Partially related - ocsf/ocsf-server#88

Description of changes:

  1. Adding requirement attributes in schema definition files, wherever missing. Making requirement definition consistent throughout the framework. This will eliminate warnings during server builds.
  2. Minor bugfixes in schema definition files
  3. Adding a basic gitignore
  4. Adjusting the pr template to remove requirement of having labels. (only github org members are able to assign labels so non-members aren't able to assign them. We can let PR reviewers can assign labels as necessary.

@floydtree floydtree added framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes labels May 2, 2024
@floydtree floydtree requested a review from dkolbly May 2, 2024 17:02
@floydtree floydtree changed the title General schema definition files cleanup General schema definition file cleanup May 2, 2024
@mikeradka
Copy link
Contributor

This is great. Question for you @floydtree - I noticed yesterday that the dictionary attributes aren't wholly alphabetized and was considering putting in a PR. Is this something you'd like to include in this cleanup, or would you rather I put in a fresh PR?

@floydtree floydtree changed the title General schema definition file cleanup General cleanup of schema definition files May 2, 2024
@floydtree
Copy link
Contributor Author

This is great. Question for you @floydtree - I noticed yesterday that the dictionary attributes aren't wholly alphabetized and was considering putting in a PR. Is this something you'd like to include in this cleanup, or would you rather I put in a fresh PR?

Yep good catch! I'll include it in this PR. The change should now be in.

Signed-off-by: Rajas Panat <[email protected]>
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the cleanup.

Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pagbabian-splunk pagbabian-splunk merged commit 3935ff4 into ocsf:main May 3, 2024
2 checks passed
@floydtree floydtree deleted the schema-cleanup branch May 3, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants