-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General cleanup of schema definition files #1071
Conversation
Signed-off-by: Rajas Panat <[email protected]>
Signed-off-by: Rajas Panat <[email protected]>
Signed-off-by: Rajas Panat <[email protected]>
Signed-off-by: Rajas Panat <[email protected]>
Signed-off-by: Rajas Panat <[email protected]>
This is great. Question for you @floydtree - I noticed yesterday that the dictionary attributes aren't wholly alphabetized and was considering putting in a PR. Is this something you'd like to include in this cleanup, or would you rather I put in a fresh PR? |
Signed-off-by: Rajas Panat <[email protected]>
Signed-off-by: Rajas Panat <[email protected]>
Yep good catch! I'll include it in this PR. The change should now be in. |
Signed-off-by: Rajas Panat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue:
Partially related - ocsf/ocsf-server#88
Description of changes: