Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [#1091] - extension of package by vendor_name and type #1093

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

PavelJurka
Copy link
Contributor

Related Issue:

#1091

Description of changes:

Extension of package by vendor_name and type_id + type of Application, Operation System, Unknown, Other

objects/package.json Outdated Show resolved Hide resolved
@davemcatcisco
Copy link
Contributor

Just realised I've been commenting on PRs using my personal GitHub account @davemcincork. It's me. Honest!

mikeradka
mikeradka previously approved these changes May 28, 2024
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @PavelJurka

CHANGELOG.md Outdated Show resolved Hide resolved
@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF findings Issues related to Findings Category labels May 28, 2024
zschmerber
zschmerber previously approved these changes May 28, 2024
mikeradka
mikeradka previously approved these changes May 30, 2024
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

floydtree
floydtree previously approved these changes May 30, 2024
@PavelJurka PavelJurka dismissed stale reviews from floydtree and mikeradka via d754729 May 31, 2024 11:19
@pagbabian-splunk pagbabian-splunk merged commit c0a18f2 into ocsf:main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants