Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing domain attribute to URL object #1096

Merged
merged 2 commits into from
May 23, 2024
Merged

Add missing domain attribute to URL object #1096

merged 2 commits into from
May 23, 2024

Conversation

mikeradka
Copy link
Contributor

Related Issue: N/A

Description of changes:

We noticed that the url object has subdomain, but not domain. This PR adds the domain attribute to the existing url object:

image

@mikeradka
Add domain attribute
3180af9 
Signed-off-by: Michael Radka <[email protected]>
@mikeradka
Update CHANGELOG
fbe17bd 
Signed-off-by: Michael Radka <[email protected]>
@mikeradka mikeradka self-assigned this May 23, 2024
@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes network_activity Issues related to Network Activity Category v1.3.0 Changes marked for v1.3.0 of OCSF labels May 23, 2024
@mikeradka mikeradka merged commit f39cb45 into ocsf:main May 23, 2024
2 checks passed
@mikeradka mikeradka deleted the add_domain_attribute_to_url branch May 23, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@floydtree floydtree floydtree approved these changes

@jonrau-at-queryai jonrau-at-queryai jonrau-at-queryai approved these changes

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

@ablyler ablyler Awaiting requested review from ablyler

@alanisaac alanisaac Awaiting requested review from alanisaac

@adplotzk adplotzk Awaiting requested review from adplotzk

Assignees

@mikeradka mikeradka

Labels
enhancement New feature or request network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeradka @pagbabian-splunk @floydtree @jonrau-at-queryai