Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding credential_uid as an observable type, misc Changelog fixes #1137

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

floydtree
Copy link
Contributor

Related Issue: n/a

Description of changes:

  1. Adding credential_uid as an observable type, type_id 19.
  2. Misc Changelog fixes

@floydtree floydtree added non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF labels Jul 2, 2024
Signed-off-by: Rajas Panat <[email protected]>
@floydtree floydtree marked this pull request as ready for review July 2, 2024 18:20
@mikeradka
Copy link
Contributor

mikeradka commented Jul 2, 2024

The schema update itself looks good, but just a sanity check - is this why 19 was omitted in the first place, or was there some oversight or some other reason for that?

image

@floydtree
Copy link
Contributor Author

The schema update itself looks good, but just a sanity check - is this why 19 was omitted in the first place, or was there some oversight or some other reason for that?
image

We never reached 19 prior to this. The gap existed because of the initial segmentation that we had in place for scalar vs object observable entities.

mikeradka
mikeradka previously approved these changes Jul 9, 2024
mikeradka
mikeradka previously approved these changes Jul 9, 2024
@floydtree floydtree merged commit 079ef53 into ocsf:main Jul 10, 2024
2 checks passed
@floydtree floydtree deleted the cred_uid_observ branch July 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants