Enums with only the nominal values (0/99 or 99) in dictionary have 'See specific usage' in the description #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmitch
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
…ecific usage" in the description `algorithm_id` description grammar tweaked `classification_ids` definition details pushed down into it's specific use `disposition_id` definition brought entirely into `dictionary.json` `flag_ids` description has "See specific usage" added `integrity_id` definition brought entirely into `dictionary.json` `load_type_id` definition details pushed down into it's specific use Signed-off-by: Mitchell Wasson <[email protected]>
mlmitch
force-pushed
the
enum-definition-and-specific-usage
branch
from
c0bd360
to
3c85501
Compare
|
The one attribute I didn't touch with this change is I can add this, but I wanted to see if this would be a good addition before I do the typing. |
mikeradka
approved these changes
Jul 23, 2024
mikeradka
approved these changes
Jul 23, 2024
floydtree
approved these changes
Jul 23, 2024
pagbabian-splunk
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was a suggestion from @pagbabian-splunk in #1111
After this PR, all enums that are defined in
dictionary.jsonwith only the nominal values (0/99 or 99) also have 'See specific usage' in the description.The effect is that a warning will be generated by the OCSF server if these attributes are used without overriding the description.
The process for these changes was:
dictionary.jsononly has 0/99 and 'See specific usage' is in description. The use of the enum has the additional enum values and a description override.dictionary.jsonand the use of it only specifies optionality.