Added new activity Listen to Network Activity and relax requirement of src_endpoint
#1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmitch
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
mlmitch
changed the title
Network Activity and relax requirement of src_endpointListen to Network Activity and relax requirement of src_endpoint
…nt of `src_endpoint` This adds support for representing a network endpoint listening for new network connections on a network. The listening network endpoint will always be the `dst_endpoint`, and there is no `src_endpoint` because no network connection has been established yet. Therefore `src_endpoint` is changed from required to recommended. Signed-off-by: Mitchell Wasson <[email protected]>
floydtree
approved these changes
Jul 22, 2024
zschmerber
approved these changes
Jul 23, 2024
rmouritzen-splunk
approved these changes
Jul 23, 2024
mikeradka
requested changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for representing a network endpoint listening for new network connections on a network.
The listening network endpoint will always be the
dst_endpoint, and there is nosrc_endpointbecause no network connection has been established yet. Thereforesrc_endpointis changed from required to recommended.The rational behind using
Network Activityis that when a data consumer asks their data set forNetwork Activity, they will probably be interested in things that are listening on the network even if there wasn't a connection established yet.This is in contrast to needing to ask the data set for a different event type.