Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing inconsistencies in the findings classes, other desc corrections #1150

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fixing inconsistencies in the findings classes, other desc corrections #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c643e23
fixing inconsistencies in the findings classes, other desc corrections
floydtree Jul 26, 2024
ba6a916
Adding a changelog entry
floydtree Jul 26, 2024
e771853
Merge branch 'main' into findings_fix
floydtree Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Thankyou! -->
5. Added `ticket` to `Incident Finding` event class. #1068
6. Added new activities `Enroll`, `Activate`, `Deactivate`, `Suspend`, and `Resume` to the `Entity Management` class. #1095
7. Added new activity `Listen` to `Network Activity` and relax requirement of `src_endpoint`. #1147
8. Added `resources` attribute to `Vulnerability Finding` and `Compliance Finding`. #1150
* #### Profiles
* #### Objects
1. Added `ext` to `File` object. #1046
Expand All @@ -96,6 +97,7 @@ Thankyou! -->
3. Fixed declarations of `data_lifecycle_state_id`, `integrity`, `opcode_id`, `risk_level`, and `analytic.type_id`. #1111

### Deprecated
1. Deprecated `resource` in `Vulnerability Finding` and `Compliance Finding` event classes in favor of `resources`. #1150

### Breaking changes

Expand Down
9 changes: 9 additions & 0 deletions events/findings/compliance_finding.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,18 @@
"requirement": "recommended"
},
"resource": {
"@deprecated": {
"message": "Use the <code>resources</code> attribute instead.",
"since": "1.3.0"
},
"description": "Describes details about the resource that is the subject of the compliance check.",
"group": "primary",
"requirement": "recommended"
},
"resources": {
"description": "Describes details about the resource/resouces that are the subject of the compliance check.",
"group": "primary",
"requirement": "recommended"
}
}
}
2 changes: 1 addition & 1 deletion events/findings/data_security_finding.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
},
"resources": {
"caption": "Affected Resources",
"description": "Describes details about resources twhere classified or sensitive data is stored in, or was accessed from.",
"description": "Describes details about resources where classified or sensitive data is stored in, or was accessed from.",
"group": "context",
"requirement": "recommended"
},
Expand Down
10 changes: 10 additions & 0 deletions events/findings/vulnerability_finding.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,20 @@
"uid": 2,
"attributes": {
"resource": {
"@deprecated": {
"message": "Use the <code>resources</code> attribute instead.",
"since": "1.3.0"
},
"description": "Describes details about the resource that is affected by the vulnerability/vulnerabilities.",
"group": "primary",
"requirement": "recommended"
},
"resources": {
"caption": "Affected Resources",
"description": "Describes details about the resource/resources that are affected by the vulnerability/vulnerabilities.",
"group": "primary",
"requirement": "recommended"
},
"vulnerabilities": {
"group": "primary",
"requirement": "required"
Expand Down
Loading