-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zone to managed entity object #1181
base: main
Are you sure you want to change the base?
Add Zone to managed entity object #1181
Conversation
Signed-off-by: Martin McCloskey <[email protected]>
Signed-off-by: Martin McCloskey <[email protected]>
Signed-off-by: Martin McCloskey <[email protected]>
Signed-off-by: Martin McCloskey <[email protected]>
After looking at a zone.update log in Okta, i seems like the structure of the data my need to be carried by an array, also I see a zone https://schema.ocsf.io/1.3.0/objects/device?extensions= field in the schema so we would have a collision with adding a new object with the same name. |
Nice draft, @max-power15. I believe adding a
|
Great feedback, I wasn't aware of the zone attribute. Happy to adjust the object name and the additional attribute for CIDR Is there a PR for the network profile I could check out, or is it being discussed in slack? |
Related Issue:
Managed Entity object was did not stand out as an obvious choice when reviewing Okta Network zones.
Description of changes:
type_id
enum.