Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attributes and object for patch metadata (kb_article) #702

Closed
wants to merge 14 commits into from

Conversation

jasonbreimer
Copy link
Contributor

@jasonbreimer jasonbreimer commented Jul 31, 2023

Related Issue:

#684

Related PR:

#698

Objective:

This includes attribute and object changes to allow optional enrichment of vulnerability class with patch/update meta data. The new object kb_article replaces an attribute kb_articles and contains additional details regarding the specific patch. This change will allow allow direct mapping of patch "findings" (forthcoming).

Change Details:

  1. New attributes: bulletin, classification, cpe, superseded, related_cves
  2. New Class: kb_article

Next Steps:

  1. New PR for cpe attribute added to product object.
  2. New draft PR for new Class in Discover for Patch Findings.

@jasonbreimer jasonbreimer added enhancement New feature or request findings Issues related to Findings Category labels Jul 31, 2023
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
objects/kb_article.json Outdated Show resolved Hide resolved
Copy link
Contributor

@irakledibm irakledibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"classification" is very generic attribute and may add confusion with "classifications" in our dictionary. probably it is better to call "article_classification" or "kb_classification"?

@floydtree
Copy link
Contributor

"classification" is very generic attribute and may add confusion with "classifications" in our dictionary. probably it is better to call "article_classification" or "kb_classification"?

I am okay with classification for 2 reasons -

  1. The confusion will be negated by the contextual use of that field -> kb_article.classification
  2. Adding a generic field name will help in reusability of that field down the road

Add NIST link from feedback.

Signed-off-by: Jason Reimer <[email protected]>
remove this attribute from branch dictionary. related_vulnerabilities will be used in kb_article.

Signed-off-by: Jason Reimer <[email protected]>
Based on feedback change the description and edit attribute related_cves to related_vulnerabilities. 

Signed-off-by: Jason Reimer <[email protected]>
@jasonbreimer
Copy link
Contributor Author

Yes, that was my thought for classification. I started with something like kb_classification in the dictionary but thought it might be better to create something generic so it could be re-used.

I can go either way!

@irakledibm
Copy link
Contributor

I have no objections then

irakledibm
irakledibm previously approved these changes Aug 1, 2023
floydtree
floydtree previously approved these changes Aug 1, 2023
Signed-off-by: Jason Reimer <[email protected]>
@jasonbreimer jasonbreimer dismissed stale reviews from floydtree and irakledibm via c12ba1d August 2, 2023 15:24
Signed-off-by: Jason Reimer <[email protected]>
@jasonbreimer
Copy link
Contributor Author

Rebuilding branch and PR because of merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request findings Issues related to Findings Category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants