-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New attributes and object for patch metadata (kb_article) #702
Conversation
This reverts commit abfeb8a. Remove kbarticle object change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"classification" is very generic attribute and may add confusion with "classifications" in our dictionary. probably it is better to call "article_classification" or "kb_classification"?
I am okay with classification for 2 reasons -
|
Add NIST link from feedback. Signed-off-by: Jason Reimer <[email protected]>
remove this attribute from branch dictionary. related_vulnerabilities will be used in kb_article. Signed-off-by: Jason Reimer <[email protected]>
Based on feedback change the description and edit attribute related_cves to related_vulnerabilities. Signed-off-by: Jason Reimer <[email protected]>
Yes, that was my thought for classification. I started with something like kb_classification in the dictionary but thought it might be better to create something generic so it could be re-used. I can go either way! |
I have no objections then |
Signed-off-by: Jason Reimer <[email protected]>
Signed-off-by: Jason Reimer <[email protected]>
Rebuilding branch and PR because of merge conflicts. |
Related Issue:
#684
Related PR:
#698
Objective:
This includes attribute and object changes to allow optional enrichment of vulnerability class with patch/update meta data. The new object kb_article replaces an attribute kb_articles and contains additional details regarding the specific patch. This change will allow allow direct mapping of patch "findings" (forthcoming).
Change Details:
Next Steps: