-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cpe attribute to product object #713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbreimer
added
enhancement
New feature or request
findings
Issues related to Findings Category
labels
Aug 3, 2023
floydtree
reviewed
Aug 3, 2023
floydtree
previously approved these changes
Aug 3, 2023
Aniak5
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rroupski
requested changes
Aug 11, 2023
rroupski
requested changes
Aug 18, 2023
Simplify description for the attribute within the product object. Signed-off-by: Jason Reimer <[email protected]>
remove description Signed-off-by: Jason Reimer <[email protected]>
rroupski
approved these changes
Aug 18, 2023
rroupski
requested review from
rroupski-splunk
and removed request for
rroupski-splunk
August 18, 2023 17:04
floydtree
approved these changes
Aug 18, 2023
irakledibm
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
findings
Issues related to Findings Category
v1.1.0
Changes marked for v1.1.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#684
Related PR:
#698
####Objective:
This includes addition of
cpe
attribute to theproduct
object. This change will allowvulnerability
object to includecpe
fromproduct
object to better describe a software product.####Change Details:
Edit the product object to include optional
cpe
attribute