Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpe attribute to product object #713

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Conversation

jasonbreimer
Copy link
Contributor

Related Issue:

#684

Related PR:

#698

####Objective:
This includes addition of cpe attribute to the product object. This change will allow vulnerability object to include cpe from product object to better describe a software product.

####Change Details:
Edit the product object to include optional cpe attribute

@jasonbreimer jasonbreimer added enhancement New feature or request findings Issues related to Findings Category labels Aug 3, 2023
objects/product.json Outdated Show resolved Hide resolved
@rroupski-splunk
Copy link
Contributor

Given this screenshot, what would the value of the cpe attribute? One of the CPE Names, the title, or something else?

image

floydtree
floydtree previously approved these changes Aug 3, 2023
Aniak5
Aniak5 previously approved these changes Aug 8, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

objects/product.json Outdated Show resolved Hide resolved
@jasonbreimer jasonbreimer dismissed stale reviews from Aniak5 and floydtree via 509188f August 18, 2023 16:03
objects/product.json Outdated Show resolved Hide resolved
Simplify description for the attribute within the product object.

Signed-off-by: Jason Reimer <[email protected]>
remove description

Signed-off-by: Jason Reimer <[email protected]>
@rroupski rroupski requested review from rroupski-splunk and removed request for rroupski-splunk August 18, 2023 17:04
@floydtree floydtree merged commit 69cc3f8 into ocsf:main Aug 18, 2023
1 check passed
@Aniak5 Aniak5 added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request findings Issues related to Findings Category v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants