Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MFA changes to account change schema #724

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

alanisaac
Copy link
Contributor

@alanisaac alanisaac commented Aug 15, 2023

Related Issue:

#719

Description of changes:

This PR adds two new enum values to the account_change event schema representing authentication factors being enabled and disabled for MFA.

@alanisaac alanisaac changed the title Added MFA changes to account change schema [draft] Added MFA changes to account change schema Aug 15, 2023
@rroupski
Copy link
Contributor

@alanisaac Hi Alan, this PR is a draft. Do you want to request the change, or you need more time? If you are ready, then click on the Ready for review button.

image

@alanisaac alanisaac marked this pull request as ready for review August 21, 2023 16:10
@alanisaac
Copy link
Contributor Author

@rroupski Thanks! Marked it ready for review.

@rroupski rroupski added enhancement New feature or request iam Issues related to Identity & Access Management Category non_breaking Non Breaking, backwards compatible changes labels Aug 21, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanisaac alanisaac changed the title [draft] Added MFA changes to account change schema Added MFA changes to account change schema Aug 21, 2023
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you clean up the PR description though? @alanisaac

@alanisaac
Copy link
Contributor Author

Looks good. Can you clean up the PR description though? @alanisaac

Done!

@floydtree floydtree merged commit 2994cb2 into ocsf:main Aug 21, 2023
1 check passed
@alanisaac alanisaac deleted the mfa-enable-disable branch August 21, 2023 18:49
@Aniak5 Aniak5 added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iam Issues related to Identity & Access Management Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants