Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding containers array to request and response object, to handle container activity logs #738

Merged
merged 28 commits into from
Aug 28, 2023
Merged

Adding containers array to request and response object, to handle container activity logs #738

merged 28 commits into from
Aug 28, 2023

Conversation

pladam
Copy link
Contributor

@pladam pladam commented Aug 23, 2023 •
edited
Loading

Adding containers array to request and response object, to handle container activity logs

  1. This change adds group as an optional to api object

  2. This change adds containers[] as an optional to api.request

  3. This change adds data' as an optional` to api.request

  4. This change adds containers[] as an optional to api.response

  5. This change adds data' as an optional` to api.response

  6. This change adds namespace' as an optional` to resource_details

  7. This change adds log_level as an optional to metadata object

  8. This change adds log_level to dictionary

  9. This change adds containers[] to dictionary

@pladam
Update dictionary.json
6c1e3e4 
adding verbosity field to dictionary

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update metadata.json
5eeeeb0 
adding verbosity to metadata

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update resource_details.json
1e61511 
adding namespace to resource_details

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update api.json
79203a1 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update request.json
0cf98d5 
adding data to request

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update response.json
5073691 
adding data to api response

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update request.json
ada94d4 
alphabetical sorting of attributes

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update dictionary.json
95982ff 
changing verbosity to log_level

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update metadata.json
ab4b42c 
updating log_level name in metadata object file

Signed-off-by: Adam Gregory <[email protected]>
@pladam
Update container.json
8b98d13 
changing container object to containers object array

Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding containers array to dictionary
ad01ee7 
adding containers array to dictionary

Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding container profile to api activity
c91cd8d 
adding container profile to api activity

Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding containers as optional to response.json object
bb50008 
adding containers as optional to response.json object

Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding containers array to response.json object
07c6791 
adding containers array to response.json object

Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding profile requirement to api request
bde7a44 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
adding container profile element for container events in response object
5c702bd 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
updating description of log level
50828e9 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
Merge branch 'ocsf:main' into main
8aa700e
@pladam
reverting containers change
6a17187 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
reverting addition of container profile
3d3ebc7 
Signed-off-by: Adam Gregory <[email protected]>
@pladam
reverting container profile to previous state
a494bc5 
Signed-off-by: Adam Gregory <[email protected]>
@adplotzk adplotzk requested review from rroupski, floydtree, Aniak5, mikeradka, jp-harvey and irakledibm and removed request for rroupski August 23, 2023 21:23
rroupski
rroupski requested changes Aug 23, 2023
View reviewed changes
dictionary.json Outdated Show resolved Hide resolved
objects/api.json Show resolved Hide resolved
objects/response.json Outdated Show resolved Hide resolved
objects/request.json Outdated Show resolved Hide resolved
objects/response.json Show resolved Hide resolved
objects/request.json Show resolved Hide resolved
@pladam pladam requested a review from rroupski August 25, 2023 12:57
rroupski
rroupski previously approved these changes Aug 25, 2023
View reviewed changes
mikeradka
mikeradka previously approved these changes Aug 28, 2023
View reviewed changes
@pladam pladam dismissed stale reviews from mikeradka and rroupski via 1df2ecf August 28, 2023 16:53
Aniak5
Aniak5 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rroupski rroupski merged commit 5b0cda9 into ocsf:main Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakledibm irakledibm irakledibm approved these changes

@mikeradka mikeradka mikeradka approved these changes

@Aniak5 Aniak5 Aniak5 approved these changes

@rroupski rroupski rroupski approved these changes

@floydtree floydtree Awaiting requested review from floydtree floydtree is a code owner

@jp-harvey jp-harvey Awaiting requested review from jp-harvey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pladam @rroupski @Aniak5 @mikeradka @irakledibm