-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action for deeper schema validation of PRs #830
Conversation
tested and worked beautifully
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good! For later, we should get publish the validator in a repo within the OCSF org. |
That would be my preference. I'd also like publishing control of the PyPi package to belong to the OCSF community. When the repo moves I'll wire up a GitHub action to publish to PyPi. For now, this GitHub action pulls it from PyPi, so the source can move without effecting the action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue:
N/A
Description of changes:
This PR adds a GitHub action to perform deeper validation to pushes and pull requests.
The following tests will be performed on future pull requests:
$include
,profiles
, andextends
directives can be found. [ERROR]If any ERROR or FATAL tests fail, the validator exits with a non-zero exit code and merging will be blocked (probably).
The validator is published to PyPi. Its source can currently be found at https://github.com/query-ai/ocsf-validator, but can be relocated to an OCSF repository without impacting this workflow.
The new GitHub action was tested locally with act.
Signed-off-by: Jeremy Fisher [email protected]