-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the security_control profile to include access control check semantics, and firewall profile semantics. #851
Conversation
…alware to include usage with security_control as well as finding. Updated security_control to combine the disposition list with the firewall profile list, and for use with access control checks. Signed-off-by: Paul Agbabian <[email protected]>
The change looks like a good start, firewall rules live under an optional |
As we make this change do we want to remove/deprecate the |
Yes, we will deprecate |
After composing up this schema server I see that the |
…e semantics of the Web Resource Access Activity class. Signed-off-by: Paul Agbabian <[email protected]>
…ustom' value description to use the base class message attribute for details. Signed-off-by: Paul Agbabian <[email protected]>
Yes, we need to do that, for example for the Web Resource Activity in Application Activity, in order to be able to deprecate Web Resource Access Activity. There are a number of other changes after this PR is merged - I just wanted to keep things more focused. |
…o descriptions, others were worded inconsistently. A few enums that reference external standards do not conform to the OCSF enum bracketing, e.g. those that reference standards that themselves use 0 in particular, e.g. rcode_id and stratum_id. Categoricals can fall into this situation as well. I left them alone. Signed-off-by: Paul Agbabian <[email protected]>
We need to solve for a question like this:
If we have to write: A new field in the profile like disposition_action where the result is allowed or blocked would allow us to fit all of those dispostion_id's into a simple binary result. The other option is to slim down the dispostion_id into 3-6 fields(allowed, blocked, other...) . Place the dispotion_id attributes into the connected object in the profile like "firewall_rule" and get the disposition action detail from that object. One additional idea was to use status_id but this will not capture the perspective we are looking for as the statues of an operation being run is not the same as a security control blocking or allowing something. |
I like @zschmerber's idea about a I am open to other name suggestions, but Zach and I arrived at disposition_action for it. We can get it in as a separate PR, unless @pagbabian-splunk you are okay to add that in as a part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to just need @pagbabian-splunk to incorporate @pladam descriptions. we can add the "disposition_action" field later.
…ecurity_control profile. Signed-off-by: Paul Agbabian <[email protected]>
…l disposition descriptions. Signed-off-by: Paul Agbabian <[email protected]>
Added the Updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated definitions look good and I think Action
works well, as it is common in other schemas like CIM and UDM. I think Action will be used so often that people will quickly become accustomed to its meaning and will already be used to its meaning from other schemas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, the only thing that appears to be pending is the comment on the Allowed
dispostion_id's description.
…ve firewall and termination specific language. Signed-off-by: Paul Agbabian <[email protected]>
… extra trailing period. Signed-off-by: Paul Agbabian <[email protected]>
Made the changes he suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addition of firewall_rule in this context is in line with our previous outline, approved.
Signed-off-by: Rajas <[email protected]>
Related Issue:
Firewall profile can be removed from 1.1-dev in lieu of this updated profile.
Authorization Information should be deprecated from the Actor object in lieu of this updated profile.
The Web Resource Access Activity class can be deprecated and this profile should be registered with Web Resource Activity to include the access control semantics.
Description of changes:
Per weekly call 11/14/2023 Updated the dictionary descriptions of disposition_id, firewall_rule, attacks, malware to include usage with security_control as well as finding.
Updated security_control profile to combine the disposition list with the firewall profile list, and for use with access control checks. Added the firewall_rule attribute. Added the Authorization Information attribute.