Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 854: Add URL to network activity class #857

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Issue 854: Add URL to network activity class #857

merged 2 commits into from
Nov 16, 2023

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Nov 16, 2023

Related Issue:

#854

Description of changes:

  • Create network base class to be extended by other network activity events
  • Add optional URL attribute to Network Activity event class
image

@Aniak5 Aniak5 self-assigned this Nov 16, 2023
@Aniak5 Aniak5 changed the title Issue 854: Add URL to network base class Issue 854: Add URL to network activity class Nov 16, 2023
@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Nov 16, 2023
floydtree
floydtree approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Ania.

mikeradka
mikeradka approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pagbabian-splunk pagbabian-splunk merged commit 22020b0 into ocsf:main Nov 16, 2023
2 checks passed
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@floydtree floydtree floydtree approved these changes

@mikeradka mikeradka mikeradka approved these changes

@ablyler ablyler Awaiting requested review from ablyler

Assignees

@Aniak5 Aniak5

Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aniak5 @pagbabian-splunk @floydtree @mikeradka