Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating kb_article_list (an array of the new kb_article objects) #862

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Creating kb_article_list (an array of the new kb_article objects) #862

merged 3 commits into from
Jan 3, 2024

Conversation

jasonbreimer
Copy link
Contributor

@jasonbreimer jasonbreimer commented Nov 21, 2023 •
edited by floydtree
Loading

Fix the type back to string_t for issue: 855 Breaking change in kb_articles between 1.0.0 and 1.1.0-dev
Create new kb_article_list attribute contain an array of kb or patches.

Related Issue:

#855

@jasonbreimer
new patch list array dictionary.json
f81fc03 
Fix the type back to string_t. Create new attribute patch_list that can be used by the kb_article object to contain an array of kb or patches.

Signed-off-by: Jason Reimer <[email protected]>
@jasonbreimer
fix description for patch_list
b97402a 
Signed-off-by: Jason Reimer <[email protected]>
@jasonbreimer jasonbreimer added bug Something isn't working findings Issues related to Findings Category discovery Issues related to Discovery Category labels Nov 21, 2023
@jasonbreimer jasonbreimer changed the title replace kb_articles with patch_list dictionary.json [Draft] replace kb_articles with patch_list dictionary.json Nov 21, 2023
@jasonbreimer jasonbreimer mentioned this pull request Nov 29, 2023
Closed
@jasonbreimer jasonbreimer marked this pull request as ready for review December 7, 2023 20:54
@jasonbreimer jasonbreimer changed the title [Draft] replace kb_articles with patch_list dictionary.json Replace kb_articles with patch_list dictionary.json Dec 7, 2023
@jasonbreimer jasonbreimer self-assigned this Dec 7, 2023
mikeradka
mikeradka previously approved these changes Dec 12, 2023
View reviewed changes
@floydtree floydtree added the non_breaking Non Breaking, backwards compatible changes label Dec 12, 2023
@jasonbreimer
Copy link
Contributor Author

Per today's call I will modify this to kb_article_list.

@jasonbreimer
Update dictionary.json with Kb_article_list
bc6423f 
Based upon today 1/2/24 discussion changing to Kb_article_list.

Signed-off-by: Jason Reimer <[email protected]>
@floydtree floydtree changed the title Replace kb_articles with patch_list dictionary.json Creating kb_article_list (an array of the new kb_article objects) Jan 2, 2024
floydtree
floydtree approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (fysa - updated the PR title to reflect the new name)

@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 2, 2024
pagbabian-splunk
pagbabian-splunk approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@pagbabian-splunk pagbabian-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we need to try to keep the _list convention consistent now, distinct from related_ : the first holds a list of objects, much like an array (depending on grammar, they can be used interchangeably now), the second refers to other events.

dictionary.json Show resolved Hide resolved
@pagbabian-splunk pagbabian-splunk merged commit 71222ab into ocsf:main Jan 3, 2024
2 checks passed
@floydtree floydtree mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@floydtree floydtree floydtree approved these changes

@mikeradka mikeradka mikeradka approved these changes

Assignees

@jasonbreimer jasonbreimer

Labels
bug Something isn't working discovery Issues related to Discovery Category findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonbreimer @pagbabian-splunk @floydtree @mikeradka