Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the domain attribute to the group object #871

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

mikeradka
Copy link
Contributor

@mikeradka mikeradka commented Nov 29, 2023

Description of changes:

The group object does not contain a pertinent piece of info which is common in logs: the group's domain. This PR simply adds the domain attribute to the group object.

Here are some examples of when the group's domain is logged:

image

@mikeradka mikeradka self-assigned this Nov 29, 2023
@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes labels Nov 29, 2023
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good seems like an easy add and the description makes sense.

Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@floydtree floydtree merged commit 67f975c into ocsf:main Nov 29, 2023
2 checks passed
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants