Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote class and type within dns_query/dns_answer to be recommended #879

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Demote class and type within dns_query/dns_answer to be recommended #879

merged 1 commit into from
Dec 5, 2023

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Dec 5, 2023

Related Issue:

#878

Description of changes:

  • Changed the requirement for the class and type attributes within the dns_query and dns_answer objects to be recommended instead of required.
image image

@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Dec 5, 2023
@Aniak5 Aniak5 self-assigned this Dec 5, 2023
floydtree
floydtree approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

nathanbvail
nathanbvail approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@nathanbvail nathanbvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

mikeradka
mikeradka reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mikeradka mikeradka merged commit 7096ee9 into ocsf:main Dec 5, 2023
2 checks passed
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeradka mikeradka mikeradka approved these changes

@floydtree floydtree floydtree approved these changes

@nathanbvail nathanbvail nathanbvail approved these changes

@ablyler ablyler Awaiting requested review from ablyler

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

Assignees

@Aniak5 Aniak5

Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aniak5 @nathanbvail @floydtree @mikeradka