Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to the profile including demoting the requirement of disposition_id #888

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

pagbabian-splunk
Copy link
Contributor

Related Issue:

Description of changes:

Demoted disposition_id to Recommended, adding Unauthorized and Error as dispositions, and adding more description clarifications and examples.

…osition_id to Recommended, adding Unauthorized and Error as dispositions, and adding more description clarifications and examples.

Signed-off-by: Paul Agbabian <[email protected]>
@pagbabian-splunk pagbabian-splunk added documentation Improvements or additions to documentation enhancement New feature or request non_breaking Non Breaking, backwards compatible changes labels Dec 8, 2023
@zschmerber zschmerber self-requested a review December 8, 2023 19:39
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Excited to get this one in. I have seen quite a few examples of people using status_id for the the type of info we want to capture with Action.

Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@floydtree floydtree merged commit 3596bc7 into main Dec 8, 2023
2 checks passed
@floydtree floydtree deleted the sec_ctrl3 branch December 8, 2023 20:19
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants