Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the firewall profile - #889

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Removed the firewall profile - #889

merged 3 commits into from
Dec 12, 2023

Conversation

pagbabian-splunk
Copy link
Contributor

Description of changes:

Removed the firewall profile from 1.1-dev; the security_control profile supports firewall now.

@pagbabian-splunk pagbabian-splunk added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Dec 11, 2023
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the server runs are failing, will need to remove other references to this profile

@pagbabian-splunk
Copy link
Contributor Author

Crap, sorry - missed that. Let me fix.

…es and the web_resources_activity class.

Signed-off-by: Paul Agbabian <[email protected]>
…h includes the profile for all network classes.

Signed-off-by: Paul Agbabian <[email protected]>
Copy link
Contributor

@adplotzk adplotzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing of firewall is expected and approved.

Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniak5 Aniak5 merged commit a94abe6 into main Dec 12, 2023
2 checks passed
@floydtree floydtree deleted the firewall_profile branch December 12, 2023 17:12
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants