Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "File Hash" observable Caption with "Hash" #900

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

zschmerber
Copy link
Contributor

@zschmerber zschmerber commented Dec 20, 2023

Related Issue: (#891)

Description of changes:

This change is to edit the Caption and description of Observable "File Hash" to read just "Hash"
image

@zschmerber zschmerber added the description_updates Issues related to missing/incorrect/lacking descriptions of attributes label Dec 20, 2023
@zschmerber zschmerber marked this pull request as ready for review December 20, 2023 22:08
Aniak5
Aniak5 previously approved these changes Dec 21, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

floydtree
floydtree previously approved these changes Dec 21, 2023
adding "."

Signed-off-by: Zach Schmerber <[email protected]>
@zschmerber zschmerber dismissed stale reviews from floydtree and Aniak5 via 262a815 December 22, 2023 18:19
dictionary.json Show resolved Hide resolved
@floydtree floydtree merged commit 2d76d3b into ocsf:main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description_updates Issues related to missing/incorrect/lacking descriptions of attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants