Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting the Scan event from the ICD schema. #915

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Conversation

maxhotta
Copy link
Contributor

@maxhotta maxhotta commented Jan 4, 2024

This event class describes command or user initiated scan activity.

@maxhotta maxhotta added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes application_activity Issues related to Application Activity Category v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 4, 2024
@pagbabian-splunk
Copy link
Contributor

A few comments: I think this should be part of the Discovery category rather than Application category, it fits the pattern of a proactive process to retrieve (discover) information from the network hosts.

Second: can we be more clear on the distinction between the uid and command_uid (introduced by this class)? I assume them to be different, where when a command launches it, it has an ID, and the scan process itself assigns a separate ID?

@rmouritzen-splunk
Copy link
Contributor

There's somewhat an inconsistent naming for items scanned. Sometimes it's of the form num_widgets, meaning "number of widgets scanned", and sometimes it's of the form num_kind meaning "number of kind items scanned". Perhaps being more explicit would help?

The oddballs are num_network and num_registry. Perhaps these could be num_network_nodes and num_registry_entries. Or more tersely (though arguably still intelligeable) num_net_nodes and num_reg_entries.

@maxhotta
Copy link
Contributor Author

maxhotta commented Jan 9, 2024

@pagbabian-splunk Another use case for reporting of these events are application scans that occur on a schedule (e.g., malware scans). They're not necessarily tied to a command that's issued by a remote entity. But if the application category is a concern,
we can discuss and move if deemed to be clearer. Agreed on the meaning of the id's - I'll update the descriptions to be more clear.

@maxhotta
Copy link
Contributor Author

maxhotta commented Jan 9, 2024

@rmouritzen-splunk The names may have been kept generic to allow some leeway in what they are used for. E.g., the description for num_network is the number of items - which could mean files on a network drive or perhaps nodes as you referred to. I'll check our usage as well.

dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
objects/scan.json Show resolved Hide resolved
objects/scan.json Outdated Show resolved Hide resolved
@pagbabian-splunk pagbabian-splunk merged commit fc06ae0 into ocsf:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application_activity Issues related to Application Activity Category enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants